Warn users Collect will soon require Android 8+#6927
Conversation
0d5f8c9 to
ec222e3
Compare
collect_app/src/test/java/org/odk/collect/android/mainmenu/MainMenuActivityTest.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
We should add some margins to the banner right @alyblenkin?
My guess is it should have left and right margin_standard margins.
63d0e02 to
0870128
Compare
|
As @lognaturel and I were working on the messaging around this update for the forum, we discussed maybe making this banner message shorter. Should we just update the copy at the end?
|
|
@alyblenkin ? |
|
@grzesiek2010 we are trying to simplify the messaging so the title and subtext aren't repetitive. However, I do think the bold text helps with readability. @lognaturel does that work for you? Your device will soon no longer be able to upgrade. |
|
Tested with Success! Verified cases:
|
Closes #6924
Why is this the best possible solution? Were any other approaches considered?
I’ve added the banner using the old XML layout approach, since it will be removed in v2026.1. For now, it’s more important to easily match the existing style used in components built with newer technologies (Jetpack Compose).
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Nothing special here, the banner should appear on devices running Android 7 or lower and be dismissible as described in the issue.
Do we need any specific form for testing your changes? If so, please attach one.
No.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew connectedAndroidTest(or./gradlew testLab) and confirmed all checks still passDateFormatsTest