Add a test to document that audio should not stop playing while navigating through a form#6912
Merged
seadowg merged 1 commit intogetodk:masterfrom Oct 14, 2025
Merged
Conversation
seadowg
requested changes
Oct 13, 2025
collect_app/src/androidTest/java/org/odk/collect/android/feature/formentry/AudioPlayingTest.kt
Outdated
Show resolved
Hide resolved
246c71f to
49056f7
Compare
seadowg
approved these changes
Oct 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6865
Why is this the best possible solution? Were any other approaches considered?
We discussed in the issue that allowing audio files to continue playing when a user navigates through the form might actually be a feature. It’s better to leave it as is and just add a new test to document this behavior.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
It doesn't require testing.
Do we need any specific form for testing your changes? If so, please attach one.
The form is attached to the issue.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew connectedAndroidTest(or./gradlew testLab) and confirmed all checks still passDateFormatsTest