Update mapbox to fix the issue with click listeneres#6905
Merged
grzesiek2010 merged 1 commit intogetodk:masterfrom Oct 15, 2025
Merged
Update mapbox to fix the issue with click listeneres#6905grzesiek2010 merged 1 commit intogetodk:masterfrom
grzesiek2010 merged 1 commit intogetodk:masterfrom
Conversation
afaa914 to
d02fe4b
Compare
seadowg
approved these changes
Oct 13, 2025
|
Could you send us an apk with map tokens? |
Member
Author
|
|
Tested with success Verified on device with Android 16 Verified cases:
|
|
Tested with success Verified on device with Android 10 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6896
Closes #6894
Why is this the best possible solution? Were any other approaches considered?
This issue is caused by a bug introduced in Mapbox v10.18.4.
There is no official point release with a fix, only a snapshot. It’s been taking the Mapbox team some time to resolve the problem and release an official point update. I’m creating this pull request, but let’s keep it as a draft for now to avoid testing a snapshot (and merging it) and then a point release later.EDIT: release v10.19.1 is out so I've updated the pull request.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
It should just fix the issue in Mapbox.
Do we need any specific form for testing your changes? If so, please attach one.
The forms mentioned in the issues.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew connectedAndroidTest(or./gradlew testLab) and confirmed all checks still passDateFormatsTest