Skip to content

Fix the DrawActivity theme#6903

Merged
grzesiek2010 merged 1 commit intogetodk:masterfrom
grzesiek2010:COLLECT-6901
Sep 25, 2025
Merged

Fix the DrawActivity theme#6903
grzesiek2010 merged 1 commit intogetodk:masterfrom
grzesiek2010:COLLECT-6901

Conversation

@grzesiek2010
Copy link
Member

@grzesiek2010 grzesiek2010 commented Sep 22, 2025

Closes #6901

Why is this the best possible solution? Were any other approaches considered?

It's just a small fix in the theme, nothing to explain here.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

It should just fix the theme.

Do we need any specific form for testing your changes? If so, please attach one.

No.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

  • added or modified tests for any new or changed behavior
  • run ./gradlew connectedAndroidTest (or ./gradlew testLab) and confirmed all checks still pass
  • added a comment above any new strings describing it for translators
  • added any new strings with date formatting to DateFormatsTest
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@grzesiek2010 grzesiek2010 marked this pull request as ready for review September 22, 2025 20:23
@seadowg seadowg removed the request for review from lognaturel September 25, 2025 14:58
@grzesiek2010 grzesiek2010 merged commit 44684c0 into getodk:master Sep 25, 2025
6 checks passed
@WKobus
Copy link

WKobus commented Sep 26, 2025

Tested with success

Verified on Android 16

Verified cases:

  • Exit dialogs in Signature, Draw and Annotate widgets
  • Dark and light theme
  • Different font sizes
  • RTL language
  • Regression checks in Signature, Draw and Annotate widgets

@dbemke
Copy link

dbemke commented Sep 26, 2025

Tested with success

Verified on Android 10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Buttons in exit dialog from signature draw and markup widget

4 participants