Add tests for foreground notifications#6902
Merged
grzesiek2010 merged 29 commits intogetodk:masterfrom Nov 12, 2025
Merged
Conversation
6 tasks
2f9bbcf to
37f6db7
Compare
grzesiek2010
requested changes
Nov 3, 2025
androidshared/src/main/java/org/odk/collect/androidshared/utils/RuntimeUniqueIdGenerator.kt
Outdated
Show resolved
Hide resolved
androidshared/src/main/java/org/odk/collect/androidshared/utils/InMemUniqueIdGenerator.kt
Outdated
Show resolved
Hide resolved
androidshared/src/main/java/org/odk/collect/androidshared/utils/RuntimeUniqueIdGenerator.kt
Outdated
Show resolved
Hide resolved
collect_app/src/androidTest/java/org/odk/collect/android/support/async/AsyncWorkTracker.kt
Outdated
Show resolved
Hide resolved
...pp/src/androidTest/java/org/odk/collect/android/support/async/TrackingCoroutineDispatcher.kt
Outdated
Show resolved
Hide resolved
androidshared/src/main/java/org/odk/collect/androidshared/utils/InMemUniqueIdGenerator.kt
Show resolved
Hide resolved
...c/androidTest/java/org/odk/collect/android/support/async/AsyncWorkTrackerIdlingResource.java
Outdated
Show resolved
Hide resolved
...dTest/java/org/odk/collect/android/support/async/TrackingCoroutineAndWorkManagerScheduler.kt
Show resolved
Hide resolved
a302b6a to
343f2bb
Compare
cdc1a61 to
c135d8a
Compare
15f1c71 to
99752cb
Compare
44e2561 to
26f4853
Compare
grzesiek2010
requested changes
Nov 7, 2025
| @@ -0,0 +1,7 @@ | |||
| package org.odk.collect.androidshared.utils | |||
|
|
|||
| class RuntimeUniqueIdGeneratorTest : UniqueIdGeneratorTest() { | |||
Member
There was a problem hiding this comment.
This should be called InMemUniqueIdGeneratorTest
androidshared/src/main/java/org/odk/collect/androidshared/utils/InMemUniqueIdGenerator.kt
Show resolved
Hide resolved
grzesiek2010
approved these changes
Nov 12, 2025
|
Tested with success Verified on Android 16 Verified cases:
|
|
Tested with success Verified on Android 10 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #6900
This adds tests as well as fixing the bugs fixed in #6900 within the new structure.
Why is this the best possible solution? Were any other approaches considered?
Now, foreground service work manager jobs are run using real
WorkManagerinfrastructure in tests. Deferred work still just runs on a standard background thread, but that seems like a fair trade-off for being able to control when they run still.How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
There's been some changes made to how background jobs work in general, so I think testing repeated jobs (like match exactly) as well as manually syncs (again with match exactly) is a good idea.
Before submitting this PR, please make sure you have:
./gradlew connectedAndroidTest(or./gradlew testLab) and confirmed all checks still passDateFormatsTest