Change default guidance hint mode#6899
Conversation
collect_app/src/androidTest/java/org/odk/collect/android/feature/formentry/GuidanceTest.kt
Outdated
Show resolved
Hide resolved
|
Should guidance setting change after upgrade to newest master in projects that were added before this change? |
You mean from |
It should already I think? If the value is not set, the new default should be used. There's an exception if a project was created from a QR code though as I mentioned in the PR description:
Is that all working as expected @WKobus? |
|
I think yea, just to be sure, I added project in Collect v2025.3.0 by scanning app user from central ( hint setting was set to "No") and then upgraded to the newest master, hint setting was still set to "No" it is expected right? |
Yeah, that sounds right. |
|
Tested with success Verified on device with Android 16 Verified cases:
|
|
Tested with success Verified on device with Android 10 |
Closes #6639
Why is this the best possible solution? Were any other approaches considered?
I think an obvious additional piece of work that could have been done here would have been to pull out a new view component for the guidance hint. This issue was a small design tweak, and I was timeboxing it to an hour just to finish off my week - I had a quick peak at extracting a view, but it was definitely another chunk of work.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Should just change the default for new and existing projects. Projects that have set a guidance hint mode or already won't be affected. Additionally, I'd expect projects imported from QR codes (like those from Central) to be unaffected as importing from a QR code saves the default value at the time of import.
Before submitting this PR, please make sure you have:
./gradlew connectedAndroidTest(or./gradlew testLab) and confirmed all checks still passDateFormatsTest