Upgrade Mapbox to fix 16 KB alignment issues#6880
Conversation
gradle/libs.versions.toml
Outdated
| playServicesLocation = { group = "com.google.android.gms", name = "play-services-location", version = "21.3.0" } | ||
| playServicesOssLicenses = { group = "com.google.android.gms", name = "play-services-oss-licenses", version = "17.1.0" } | ||
| mapboxAndroidSdk = { group = "com.mapbox.maps", name = "android", version = "10.16.4" } # Check if https://github.com/mapbox/mapbox-maps-android/issues/2389#issuecomment-2432018812 no longer takes place before upgrading | ||
| mapboxAndroidSdk = { group = "com.mapbox.maps", name = "android-ndk27", version = "10.19.0" } |
There was a problem hiding this comment.
v10.19.0 seems to be free of that bug (I think it exists in v11+). We should keep the comment so that next time we try to upgrade, we remember to check it.
There was a problem hiding this comment.
Does that not imply the bug is fixed though? I was thinking we should reply on the issue so they can close it if it's not in that version.
There was a problem hiding this comment.
No, because you’re using v10.x, which never had that bug. The bug was introduced in v11.x.
https://github.com/getodk/collect/pull/6467/files#diff-d4be40bb49cbd2e0529fd0efc0469d2074f8d77b306d8e3ceb62cc395f20e2cdL25
There was a problem hiding this comment.
Ah, sorry I'd misunderstood. I can add the comment back in.
|
Could you send us the apk with map tokens? I created a debug one and I'm not sure if something I found is an issue or some debug version problem. |
|
Ah sorry I'd thought #6862 had already merged, but I was wrong! I'll send an APK on Slack. |
|
Tested with Success! Verified on Android 10 Verified cases:
|
|
Tested with success Verified on Android 16 |
|
Tested with success Verified on Android 14 |
Closes #6798
Why is this the best possible solution? Were any other approaches considered?
Updating our lint revealed that it was only Mapbox libs causing problems here. We had frozen the version of Mapbox we use until an issue was addressed (mapbox/mapbox-maps-android#2389 (comment)), but being able to deploy to the Play Store will obviously take precedence.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
There should be no changes visible here. I've tested that the app (using Mapbox) works in a 16 KB environment using the steps from Android's docs, so that shouldn't need validated. The main things to check manually here will be maps using Mapbox. It could be that mapbox/mapbox-maps-android#2389 (comment), is still present, and if so we'll want to take the plunge in upgrading to the newest version to see if that helps.
Before submitting this PR, please make sure you have:
./gradlew connectedAndroidTest(or./gradlew testLab) and confirmed all checks still passDateFormatsTest