Skip to content

Update markup and signature exit model with new styling#6300

Merged
seadowg merged 9 commits intogetodk:masterfrom
grzesiek2010:COLLECT-6117
Sep 19, 2025
Merged

Update markup and signature exit model with new styling#6300
seadowg merged 9 commits intogetodk:masterfrom
grzesiek2010:COLLECT-6117

Conversation

@grzesiek2010
Copy link
Member

@grzesiek2010 grzesiek2010 commented Jul 31, 2024

Closes #6117

Why is this the best possible solution? Were any other approaches considered?

The new dialog is similar to the one we display on quitting a form so the implementation is also similar. Nothing special to discuss here.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

We need to test the three widgets:

  • Signature widget
  • Draw widget
  • Annotate widget

to confirm the dialog displayed on quitting the drawing screen works well. I don't think there is anything else risky that should be tested.

Do we need any specific form for testing your changes? If so, please attach one.

No, we can use the All question types form from the demo server.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

  • added or modified tests for any new or changed behavior
  • run ./gradlew connectedAndroidTest (or ./gradlew testLab) and confirmed all checks still pass
  • added a comment above any new strings describing it for translators
  • added any new strings with date formatting to DateFormatsTest
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@grzesiek2010 grzesiek2010 requested a review from seadowg July 31, 2024 21:59
@grzesiek2010 grzesiek2010 marked this pull request as ready for review July 31, 2024 21:59
@seadowg seadowg merged commit d41f1da into getodk:master Sep 19, 2025
6 checks passed
@WKobus
Copy link

WKobus commented Sep 26, 2025

Tested with success

Verified on Android 16

Verified cases:

  • Exit dialogs in Signature, Draw and Annotate widgets
  • Dark and light theme
  • Different font sizes
  • RTL language
  • Regression checks in Signature, Draw and Annotate widgets

@dbemke
Copy link

dbemke commented Sep 26, 2025

Tested with success

Verified on Android 10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update markup and signature exit model with new styling

4 participants