Update What's New modal for 2025.4: maps, bulk entity delete, etc.#1434
Merged
Update What's New modal for 2025.4: maps, bulk entity delete, etc.#1434
Conversation
ktuite
commented
Dec 6, 2025
ktuite
commented
Dec 6, 2025
ktuite
commented
Dec 6, 2025
matthew-white
approved these changes
Dec 6, 2025
419a0a9 to
657b707
Compare
Member
Author
|
Still need to
|
657b707 to
a30b27a
Compare
a30b27a to
2d8b925
Compare
src/components/whats-new.vue
Outdated
| @@ -1,3 +1,4 @@ | |||
| <!-- eslint-disable vuejs-accessibility/alt-text --> | |||
Member
There was a problem hiding this comment.
I think it'd be a little better to put this right above the first <template>. We do that in a few other cases. That way the copyright, etc. can continue to start on the first line.
Comment on lines
-122
to
-123
| <!-- Autogenerated by destructure.js --> | ||
| <i18n> |
Member
There was a problem hiding this comment.
You don't need to delete this manually, it will be modified automatically when translations are updated.
src/components/whats-new.vue
Outdated
| // When updating `canUpdateForm` in the future, consider the *verb* for the audience. | ||
| // For 2025.4, we decided it could be shown to project viewers as well, | ||
| // where the previous modal was only shown to admins and project managers. | ||
| const canUpdateForm = currentUser.can('form.update') || |
Member
There was a problem hiding this comment.
Suggested change
| const canUpdateForm = currentUser.can('form.update') || | |
| const canUpdateForm = currentUser.can('submission.list') || |
I think the two verbs on this line and the next should be consistent.
cc4d7bc to
7d5ba0e
Compare
Member
Author
|
I am planning to come back and fix the e2e test in a new PR by modifying the test to update the user preference ahead of time to dismiss the modal. |
This was referenced Dec 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes getodk/central#1487
What has been done to verify that this works as intended?
Why is this the best possible solution? Were any other approaches considered?
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Does this change require updates to user documentation? If so, please file an issue here and include the link below.
Before submitting this PR, please make sure you have:
npm run testandnpm run lintand confirmed all checks still pass OR confirm CircleCI build passes