submissions/odata: allow filtering by instanceId (__id)#1630
Merged
matthew-white merged 5 commits intogetodk:masterfrom Oct 19, 2025
Merged
submissions/odata: allow filtering by instanceId (__id)#1630matthew-white merged 5 commits intogetodk:masterfrom
matthew-white merged 5 commits intogetodk:masterfrom
Conversation
Related: #1401
matthew-white
approved these changes
Oct 15, 2025
Member
|
Just a random aside, but you don't need to add PRs to the project if there's already an issue associated with them. We just add PRs to the project when we want to track the status of the work (for planning or timeline reasons or for release notes), yet there's no associated issue to use. |
Member
|
@alxndrsn, I'm going to go ahead and merge. Hope that's OK! I know you usually prefer to merge your own PRs, but the timeline on mapping-related things is pretty tight, and we need this change on staging by Tuesday. |
Member
|
If any changes need to be made, that could happen in a follow-up PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes getodk/central#1401
What has been done to verify that this works as intended?
New tests, existing tests.
Why is this the best possible solution? Were any other approaches considered?
Follows the pattern of other similar code.
Is the
__idcorrect for the filter field's name? Should it be e.g.__system/id?How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Adds an extra option for odata filtering of submissions.
Regression risks seem minimal, unless users can create custom fields called
__id.Does this change require updates to the API documentation? If so, please update docs/api.yaml as part of this PR.
✅
Before submitting this PR, please make sure you have:
make testand confirmed all checks still pass OR confirm CircleCI build passes