• inline _defInsert()
• invert INSERT query to replace nextval() with standard key generation
• reduce data returned from PostgreSQL which NodeJS already has
• reformat main query

Follow-up to #1606

Having read _defInsert() enough times to understand it, it seemed helpful to rewrite it. I assume the reason why the submission_def was being inserted before the submission was to allow use of _defInsert() by both Submissions.createNew() and Submissions.createVersion(), which is no longer happening.

What has been done to verify that this works as intended?

CI.

Why is this the best possible solution? Were any other approaches considered?

• This PR inverts the insertion order of submission and submission_def to rely on PostgreSQL to assign the submission's id. This is orthogonal to decreasing the data passed between PostgreSQL and NodeJS.
• This PR could be changed to return query formatting to match the original more closely. To me this makes understanding the query significantly harder.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

No effect

Does this change require updates to the API documentation? If so, please update docs/api.yaml as part of this PR.

No.

Before submitting this PR, please make sure you have:

• run make test and confirmed all checks still pass OR confirm CircleCI build passes
• verified that any code from external sources are properly credited in comments or that everything is internally sourced