odata-filter: support yoda notation for null equality#1557
Merged
alxndrsn merged 5 commits intogetodk:masterfrom Jul 30, 2025
Merged
odata-filter: support yoda notation for null equality#1557alxndrsn merged 5 commits intogetodk:masterfrom
alxndrsn merged 5 commits intogetodk:masterfrom
Conversation
added 2 commits
July 28, 2025 10:09
Previously, this code could generate SQL statements saying `NULL IS ...`. In postgres, this is invalid syntax: # SELECT (NULL IS '1'); ERROR: syntax error at or near "'1'" LINE 1: SELECT (NULL IS '1');
* check for equality in addition to inequality * share more code
sadiqkhoja
reviewed
Jul 29, 2025
Contributor
sadiqkhoja
left a comment
There was a problem hiding this comment.
thanks! looks good to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, this code could generate SQL statements saying
NULL IS .... In postgres, this is invalid syntax:Noted while reviewing #1521
What has been done to verify that this works as intended?
Added new integration tests:
Why is this the best possible solution? Were any other approaches considered?
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Fixes a bug.
Does this change require updates to the API documentation? If so, please update docs/api.yaml as part of this PR.
No.
Before submitting this PR, please make sure you have:
make testand confirmed all checks still pass OR confirm CircleCI build passes