Skip to content

nginx: reject requests with unexpected Host header#747

Closed
alxndrsn wants to merge 8 commits intogetodk:nextfrom
alxndrsn:enforce-host-check-https
Closed

nginx: reject requests with unexpected Host header#747
alxndrsn wants to merge 8 commits intogetodk:nextfrom
alxndrsn:enforce-host-check-https

Conversation

@alxndrsn
Copy link
Contributor

@alxndrsn alxndrsn commented Oct 9, 2024

No description provided.

@alxndrsn alxndrsn changed the title nginx: reject HTTPS requests with unexpected Host header nginx: reject requests with unexpected Host header Oct 9, 2024
@alxndrsn alxndrsn marked this pull request as draft October 9, 2024 08:24
@alxndrsn
Copy link
Contributor Author

alxndrsn commented Oct 9, 2024

CircleCI build needs fixing, probably around:

docker run --network container:project-nginx-1 appropriate/curl -4 --insecure --retry 30 --retry-delay 10 --retry-connrefused https://localhost/

@alxndrsn
Copy link
Contributor Author

alxndrsn commented Oct 9, 2024

Sometimes CNAME is set to "local":

CNAME=$( [ "$SSL_TYPE" = "customssl" ] && echo "local" || echo "$DOMAIN") \

Perhaps DOMAIN should be used in place of CNAME.

@alxndrsn alxndrsn marked this pull request as ready for review October 15, 2024 08:09
@alxndrsn alxndrsn requested a review from yanokwa October 15, 2024 08:09
@alxndrsn
Copy link
Contributor Author

alxndrsn commented Dec 3, 2024

Closing in favour of #809, which looks more idiomatic.

@alxndrsn alxndrsn closed this Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant