Skip to content

Fix compile error#387

Merged
getnamo merged 9 commits intogetnamo:masterfrom
lehuan5062:master
Sep 26, 2023
Merged

Fix compile error#387
getnamo merged 9 commits intogetnamo:masterfrom
lehuan5062:master

Conversation

@lehuan5062
Copy link
Copy Markdown
Contributor

@lehuan5062 lehuan5062 commented Aug 23, 2023

There are 2 kinds of issues when compiling a project which has this plugin:

  • "No such file or directory" when compiling.
  • "undeclared identifier" when packaging.

This pull request should fix these issues.

fatal error C1083: Cannot open include file: 'Engine/Classes/Sound/SoundWaveProcedural.h': No such file or directory
fatal error C1083: Cannot open include file: 'Engine/Classes/Engine/LatentActionManager.h': No such file or directory
EngineVersion isn't needed, it's automatically added when package from unreal
@lehuan5062 lehuan5062 marked this pull request as draft September 3, 2023 06:17
@lehuan5062 lehuan5062 marked this pull request as ready for review September 5, 2023 03:03
@getnamo
Copy link
Copy Markdown
Owner

getnamo commented Sep 20, 2023

Will check this over soon and see if it meets 5.3 merge needs. Thanks for opening a pull

@getnamo
Copy link
Copy Markdown
Owner

getnamo commented Sep 26, 2023

pulled into https://github.com/getnamo/SocketIOClient-Unreal/tree/feature-5.3 branch for testing before merging

@getnamo getnamo merged commit 9268409 into getnamo:master Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants