Skip to content

Conversation

@viren-nadkarni
Copy link
Contributor

@viren-nadkarni viren-nadkarni commented Aug 12, 2025

This PR adds support for following EBS-related properties when creating EMR clusters:

The behaviour has been verified with AWS. A test is also included.

@codecov
Copy link

codecov bot commented Aug 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.82%. Comparing base (c550fb9) to head (eeb9674).
⚠️ Report is 22 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9165      +/-   ##
==========================================
+ Coverage   92.79%   92.82%   +0.02%     
==========================================
  Files        1276     1276              
  Lines      113728   113973     +245     
==========================================
+ Hits       105534   105790     +256     
+ Misses       8194     8183      -11     
Flag Coverage Δ
servertests 28.62% <0.00%> (+0.03%) ⬆️
unittests 92.79% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@viren-nadkarni viren-nadkarni marked this pull request as ready for review August 12, 2025 10:25
Copy link
Collaborator

@bblommers bblommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you @viren-nadkarni!

@bblommers bblommers added this to the 5.1.11 milestone Aug 12, 2025
@bblommers bblommers merged commit 899a7c7 into getmoto:master Aug 12, 2025
58 checks passed
@viren-nadkarni viren-nadkarni deleted the emr-ebs-vols branch August 22, 2025 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants