Skip to content

Conversation

@groyoh
Copy link
Contributor

@groyoh groyoh commented Jul 16, 2025

This also updates the setup.cfg to include ruff as a dependency and add a "Linting" section in the README.

@groyoh groyoh force-pushed the feat/sub-termination-no-credit-note branch from 1310fed to 0340f8c Compare July 16, 2025 13:34
@groyoh groyoh force-pushed the feat/sub-termination-no-credit-note branch from 0340f8c to 4421899 Compare July 16, 2025 13:50
@groyoh groyoh marked this pull request as ready for review July 16, 2025 14:34
Copy link
Contributor

@julienbourdeau julienbourdeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So no change was required at all? Nice

@groyoh
Copy link
Contributor Author

groyoh commented Jul 18, 2025

@julienbourdeau exactlyt, it's already working with client.subscriptions.destroy(external_id, { "on_termination_credit_note": "skip" }). But I forgot to check the attribute in the response in the test. I'll update that. Thanks for the review!

@groyoh groyoh merged commit cea0810 into main Jul 18, 2025
7 checks passed
@groyoh groyoh deleted the feat/sub-termination-no-credit-note branch July 18, 2025 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants