fix(stats): Handle delta overflows in Counter and Countergauge #522
Merged
fwbrasil merged 4 commits intogetkyo:mainfrom Aug 2, 2024
Merged
fix(stats): Handle delta overflows in Counter and Countergauge #522fwbrasil merged 4 commits intogetkyo:mainfrom
fwbrasil merged 4 commits intogetkyo:mainfrom
Conversation
Closed
Contributor
Author
|
@fwbrasil I think this takes care of the rollover |
Collaborator
|
I think the issue was looking for a more holistic solution, but regardless tests will be necessary for this bounty claim. |
Contributor
Author
|
Working on a better solution + tests |
Contributor
Author
|
Hi @fwbrasil @hearnadam this solution addresses the overflow on |
Contributor
Author
|
@fwbrasil @hearnadam I would appreciate your feedback |
Collaborator
|
Thank you! Sorry for the delay to review @mobley-trent |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #410
/claim #410
CounterandCounterGauge