Skip to content

Introduce generalized ZLayer -> Runtime mechanism#354

Closed
hearnadam wants to merge 1 commit intogetkyo:mainfrom
hearnadam:zio-http
Closed

Introduce generalized ZLayer -> Runtime mechanism#354
hearnadam wants to merge 1 commit intogetkyo:mainfrom
hearnadam:zio-http

Conversation

@hearnadam
Copy link
Copy Markdown
Collaborator

@hearnadam hearnadam commented May 11, 2024

In an effort to resolve the issue with the zio-http benchmark, I decided to create a mechanism to convert ZLayers to Runtime.

To avoid casting, we will need to introduce an R type to all benchmarks...

I saw some weird errors when running the benchmark:

[info] Thread[#63,DestroyJavaVM,5,main]
[info] Thread[#49,KQueueEventLoopGroup-2-1,10,main]
[info]   at app//io.netty.channel.kqueue.Native.keventWait(Native Method)
[info]   at app//io.netty.channel.kqueue.Native.keventWait(Native.java:124)
[info]   at app//io.netty.channel.kqueue.KQueueEventLoop.kqueueWait(KQueueEventLoop.java:184)
[info]   at app//io.netty.channel.kqueue.KQueueEventLoop.kqueueWait(KQueueEventLoop.java:176)
[info]   at app//io.netty.channel.kqueue.KQueueEventLoop.run(KQueueEventLoop.java:245)
[info]   at app//io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:997)
[info]   at app//io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)
[info]   at app//io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
[info]   at java.base@21.0.2/java.lang.Thread.runWith(Thread.java:1596)
[info]   at java.base@21.0.2/java.lang.Thread.run(Thread.java:1583)

@hearnadam
Copy link
Copy Markdown
Collaborator Author

hearnadam commented May 21, 2024

Canceling this for now, but we should attempt something similar in the future.

@hearnadam hearnadam closed this May 21, 2024
@hearnadam hearnadam mentioned this pull request May 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@hearnadam