Merged
Conversation
Collaborator
|
I think for ZIO applications you will need to add a method which enables creating runtimes from layers (I think some of the framework is already there for the scheduler change) You should be able to do |
hearnadam
reviewed
May 6, 2024
|
|
||
| val zioUrl = | ||
| import zio.http.* | ||
| URL.decode(this.url).toOption.get |
Collaborator
There was a problem hiding this comment.
do you need the this prefix?
Collaborator
Author
There was a problem hiding this comment.
yes, it conflicts with zio.http.url
Collaborator
Author
|
I'm merging this to follow up with optimizations. I'll open a ticket for ZIO's benchmark.
Wouldn't that still initialize the client on each benchmark execution? I think we need to get a hold of a client instance to reuse across executions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm working on the performance of
Requests. I couldn't find a way to instantiatezio-http's client once and reuse it so I've disabled the benchmark for ZIO by returning a constant. Please ignore ZIO's results for now.