feat(grpc): SafeMetadata implementation (Fixes Ergonomics & Safety)#1450
Open
merchantmoh-debug wants to merge 237 commits intogetkyo:mainfrom
Open
feat(grpc): SafeMetadata implementation (Fixes Ergonomics & Safety)#1450merchantmoh-debug wants to merge 237 commits intogetkyo:mainfrom
merchantmoh-debug wants to merge 237 commits intogetkyo:mainfrom
Conversation
Author
|
@steinybot @ghostdogpr - Solved. - Just need a review - any changes let me know. This one's been sitting untouched for too long. Glad I could get it off your guys bucket list. |
Author
|
@fwbrasil @steinybot @carlosedp @nightscape Requesting review. This resolves the bounty. |
Collaborator
|
However it creates an issue with the existing PR. It's would have been easier to review with a split bounty or help on the previous PR from steinybot. Don't hesitate to reach us on discord to discuss about it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR supercedes #1334.
It introduces
SafeMetadata, an immutable, thread-safe wrapper aroundio.grpc.Metadata, solving the ergonomics issues blocking the original PR.Key Changes:
kyo.grpc.SafeMetadata(Immutable Algebra).RequestOptions,ClientCall, andServerCallHandlersto use potentially-unsafeio.grpc.MetadataONLY at the IO boundary.Closes #390
/claim #390