Screencapture example improvements#4
Closed
Be-ing wants to merge 14 commits intogethopp:expose_desktop_capturerfrom
Closed
Screencapture example improvements#4Be-ing wants to merge 14 commits intogethopp:expose_desktop_capturerfrom
Be-ing wants to merge 14 commits intogethopp:expose_desktop_capturerfrom
Conversation
Implements screen sharing by exposing libwebrtc's
DesktopCapturer.
A few platform specific notes:
- macos:
* It is using screen capture kit and the system picker by
default. If the system picker is disabled then get_sources
returns an empty list when trying to capture a display. The
display native id needs to be acquired using different means
from the client.
- linux:
* With pipewire the only way to select window or display is via
the system picker.
b866e66 to
bc67a85
Compare
so state can be moved into the callback
73dc2b7 to
8665f59
Compare
8665f59 to
8759655
Compare
886237e to
97e5a83
Compare
22 tasks
like libwebrtc's C++ API. There's no need to have the callback accessible in the same place in the code as the DesktopCapturer is instantiated and sources are enumerated.
f605040 to
22c39f2
Compare
a97df01 to
0a1bcb0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
separated from #3