Correct compatibility for gauge-ruby gem#359
Merged
chadlwilson merged 2 commits intomasterfrom Jul 12, 2024
Merged
Conversation
|
@chadlwilson Thank you for contributing to gauge-ruby. Your pull request has been labeled as a release candidate 🎉🎉. Merging this PR will trigger a release. Please bump up the version as part of this PR.Instructions to bump the version can found at CONTRIBUTING.md If the CONTRIBUTING.md file does not exist or does not include instructions about bumping up the version, please looks previous commits in git history to see what changes need to be done. |
9a746fc to
c80cda3
Compare
gauge-ruby has direct google-protobuf interaction so should have a direct dependency. google-protobuf 4 has a breaking change here which doesn't work with gauge right now. Signed-off-by: Chad Wilson <chadw@thoughtworks.com>
c80cda3 to
36f21b8
Compare
…r/stdout Seems to be to do with grpc/grpc#37178 on Linux, and only with Ruby 3.3. Excluding for now until it can be debugged further. Signed-off-by: Chad Wilson <chadw@thoughtworks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gauge-ruby is not currently compatible with google-protobuf 4 as it has a direct dependency with a breaking change. Will release a patch release that corrects the constraints to avoid people's dependabots breaking things.
Also works around an independent grpc problem with
1.65.0that is breaking the integration tests due to polluted stdout/stderr (but may not be an issue at runtime): grpc/grpc#37178