Skip to content

fix: Decimal as comma separated sale price does not save#1190

Merged
nurul-umbhiya merged 1 commit intogetdokan:developfrom
shohag121:fix/comma-separated-sale-price-does-not-save
May 7, 2021
Merged

fix: Decimal as comma separated sale price does not save#1190
nurul-umbhiya merged 1 commit intogetdokan:developfrom
shohag121:fix/comma-separated-sale-price-does-not-save

Conversation

@shohag121
Copy link
Copy Markdown
Member

@shohag121 shohag121 commented May 4, 2021

This pr fix Decimal as comma-separated sale price comparison with regular price.

fix: #1176

@shohag121 shohag121 requested a review from nurul-umbhiya May 4, 2021 05:06
@shohag121 shohag121 self-assigned this May 4, 2021
@shohag121 shohag121 added Needs: Dev Review It requires a developer review and approval Needs: Testing This requires further testing labels May 4, 2021
@nurul-umbhiya nurul-umbhiya added Dev Review Done and removed Needs: Dev Review It requires a developer review and approval labels May 5, 2021
@FaraziF FaraziF added 🎉 QA Approved This PR is approved by the QA team and removed Needs: Testing This requires further testing labels May 7, 2021
@nurul-umbhiya nurul-umbhiya merged commit b9ed3fd into getdokan:develop May 7, 2021
@shohag121 shohag121 deleted the fix/comma-separated-sale-price-does-not-save branch August 17, 2021 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dev Review Done 🎉 QA Approved This PR is approved by the QA team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Decimal as comma separated sale price does not save

3 participants