refactor: Add IChatClient with transient lifetime for all providers#116
Merged
kaspermarstal merged 2 commits intomainfrom Feb 19, 2025
Merged
refactor: Add IChatClient with transient lifetime for all providers#116kaspermarstal merged 2 commits intomainfrom
kaspermarstal merged 2 commits intomainfrom
Conversation
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IChatClients are usually registered as singletons, but transient lifetimes are necessary for us because the user can change base address or api key at runtime and these settings can only be passed via constructors.
The performance overhead of creating new instances is negligible, however, because execution time is completely dominated by model response time.
The PR adds a bit of redundant service configuration code but makes provider configuration via UI more robust (by always reading base address, api key, and model name from provider configuration), easier to reason about, and easier to maintain.