Merged
Conversation
Contributor
|
@im-adithya we also need to remove the ability to export the connection secret (for everyone) since it might have superuser permissions |
Member
Author
|
Hmmm, so we remove for all kinds of wallets then? |
17 tasks
rolznz
reviewed
Feb 25, 2025
rolznz
reviewed
Feb 25, 2025
Contributor
|
For NWA we should support scanning a QR code too (e.g. see bitcoin connect) |
rolznz
reviewed
Feb 26, 2025
rolznz
reviewed
Feb 26, 2025
rolznz
reviewed
Feb 26, 2025
rolznz
reviewed
Feb 26, 2025
rolznz
reviewed
Feb 26, 2025
im-adithya
commented
Feb 26, 2025
2 tasks
im-adithya
commented
Feb 28, 2025
im-adithya
commented
Feb 28, 2025
Member
Author
|
(Follow-up) If the app isn't requesting any budget the design looks very bad atm 
|
rolznz
reviewed
Feb 28, 2025
rolznz
reviewed
Feb 28, 2025
im-adithya
commented
Mar 3, 2025
Member
Author
im-adithya
left a comment
There was a problem hiding this comment.
Just waiting on js-sdk release, otherwise tACK (@rolznz's changes)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements the deep linking flow to create connections as described in nostr-protocol/nips#1777
Requires
feat: NWA js-sdk#298Feat: NWA auth for self-hosted hubs hub#1016Component for budgets (+ methods if we wish to do that as well)Will do in a follow-up (Add option to choosebudget_renewalandmax_amountin NWA flow #288)Screenshots
Screens to be improved in follow-ups
Deeplink Demo
ScreenRecording_02-19-2025.14-46-14_1.MP4