Swap config stage and locale stage in CMakeLists.txt#445
Merged
spe-ciellt merged 1 commit intodevelopfrom Mar 18, 2026
Merged
Conversation
At a new clone, CMake tried to create the .pot files from authors.c and bugs.c, but they were not created yet. The config stage hadn't run. The .pot files are created in locale/locale, so even if you remove the build directory the fail will not be noticed. That is why it failed at clone, but not on subsequent builds. To see the error you need to run (before this fix) rm -rf locale/locale rm -rf build cmake --preset linux-gnu-gcc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At a new clone, CMake tried to create the
.potfiles fromauthors.candbugs.c, but they were not created yet. The config stage hadn't run.The
.potfiles are created inlocale/locale, so even if you remove the build directory the fail will not be noticed. That is why it failed at clone, but not on subsequent builds.To see the error you need to run (before this fix)
Was noticed in #438