Fix missing rotation for circle primitives in GDK renderer#375
Merged
spe-ciellt merged 1 commit intogerbv:developfrom Mar 7, 2026
Merged
Conversation
gerbv_gdk_draw_prim1 was the only GDK macro primitive handler that did not apply rotation to its center coordinates. Before gerbv#310, this was masked because gerb_image.c pre-rotated the center via gerbv_rotate_coord(). Removing that pre-rotation (correctly, to fix the Cairo double-rotation bug) exposed that the GDK renderer never had its own rotation handling for circles. Apply rotate_point() to the center offset before translating, matching the pattern used by all other GDK macro primitives (prim4, prim5, prim6, prim7, prim20, prim21, prim22). Fixes gerbv#352
This was referenced Mar 6, 2026
Contributor
|
I tested it and all renderers render it correctly. Good work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gerbv_gdk_draw_prim1(circle) was the only GDK macro primitive handler that did not applyrotate_point()to its center coordinatesgerb_image.cpre-rotated the center viagerbv_rotate_coord()— the GDK renderer got already-rotated coordinatesrotate_point()to the center offset before translating, matching the pattern used by all other GDK macro primitives (prim4, prim5, prim6, prim7, prim20, prim21, prim22)Test plan
1,1,2.59,2,5,19.5— circle at center 2,5 with 19.5° rotation)