Skip to content

fix: Build authors.c before all locales.#365

Merged
spe-ciellt merged 1 commit intogerbv:developfrom
eyal0:parallel_build_locale
Mar 7, 2026
Merged

fix: Build authors.c before all locales.#365
spe-ciellt merged 1 commit intogerbv:developfrom
eyal0:parallel_build_locale

Conversation

@eyal0
Copy link
Copy Markdown
Collaborator

@eyal0 eyal0 commented Mar 5, 2026

Parallel build is failing without this because the *.pot files require config/authors.c.

@eyal0
fix: Build authors.c before all locales.
d1d5ad6 
Parallel build is failing without this because the `*.pot` files require
`config/authors.c`.
@eyal0
Copy link
Copy Markdown
Collaborator Author

eyal0 commented Mar 5, 2026

To reproduce this bug, from the root of gerbv, type:

git clean -i -x -d
mkdir build
cd build
cmake ..
make -j 20

The output of the make will be:

└──> make -j 20
make[2]: *** No rule to make target 'config/authors.c', needed by '/home/esoha/private/gerbv/locale/locale/gerbv.pot'.  Stop.
make[1]: *** [CMakeFiles/Makefile2:364: locale/CMakeFiles/gerbv-translations-ru.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
make[2]: *** No rule to make target 'config/authors.c', needed by '/home/esoha/private/gerbv/locale/locale/gerbv.pot'.  Stop.
make[1]: *** [CMakeFiles/Makefile2:332: locale/CMakeFiles/gerbv-translations-ja.dir/all] Error 2
[  2%] Building CXX object CMakeFiles/dxflib_bundled.dir/thirdparty/dxflib/dl_dxf.cpp.o
[  4%] Generating bugs.c, authors.c
[  6%] Building CXX object CMakeFiles/dxflib_bundled.dir/thirdparty/dxflib/dl_writer_ascii.cpp.o
[  9%] Building C object CMakeFiles/tinyscheme_bundled.dir/thirdparty/tinyscheme/dynload.c.o
[ 11%] Building C object CMakeFiles/tinyscheme_bundled.dir/thirdparty/tinyscheme/scheme.c.o
AUTHORS GENERATED /home/esoha/private/gerbv/AUTHORS => /home/esoha/private/gerbv/build/config/authors.c
BUGS GENERATED /home/esoha/private/gerbv/BUGS => /home/esoha/private/gerbv/build/config/bugs.c
[ 11%] Built target generated
/home/esoha/private/gerbv/thirdparty/tinyscheme/scheme.c: In function ‘Cisalpha’:
/home/esoha/private/gerbv/thirdparty/tinyscheme/scheme.c:269:44: warning: implicit declaration of function ‘isascii’ [-Wimplicit-function-declaration]
  269 | static INLINE int Cisalpha(int c) { return isascii(c) && isalpha(c); }
      |                                            ^~~~~~~
[ 13%] Linking C static library libtinyscheme_bundled.a
[ 13%] Built target tinyscheme_bundled
[ 15%] Linking CXX static library libdxflib_bundled.a
[ 15%] Built target dxflib_bundled
make: *** [Makefile:166: all] Error 2
Exit code: 2

We can see that it is trying to build gerbv.pot before the authors.c has been created. This is a mistake.

rampageservices
rampageservices approved these changes Mar 6, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@rampageservices rampageservices left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The race is between the per-language targets and the generated custom target — add_dependencies(gerbv-translations generated) only orders generated before gerbv-translations itself, not before its children gerbv-translations-ja/gerbv-translations-ru, so in a parallel build xgettext can fire before authors.c exists.

Adding the dependency to each per-language target is the correct fix.

Nit (not blocking): the existing add_dependencies(${GETTEXT_TARGET} generated) on line 69 is now redundant since all children depend on generated and the parent depends on all children. Could be removed for clarity, but harmless either way.

@eyal0
Copy link
Copy Markdown
Collaborator Author

eyal0 commented Mar 6, 2026

the existing add_dependencies(${GETTEXT_TARGET} generated) on line 69 is now redundant since all children depend on generated and the parent depends on all children. Could be removed for clarity, but harmless either way.

cmake always confuses me so I just had the AI code up the fix. Seems to work!

I'm finding these errors because I use libgerbv and not gerbv. Also, I am compiling for CI on Windows under msys2. These are probably uncommon platforms! So I'm getting these uncommon errors.

@rampageservices rampageservices mentioned this pull request Mar 7, 2026
Open
@spe-ciellt spe-ciellt added the buildsystem Updates to the buildsystem (CMake/CTest/CPack) label Mar 7, 2026
@spe-ciellt spe-ciellt merged commit 13bbc2d into gerbv:develop Mar 7, 2026
3 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Mar 8, 2026
Closed
@eyal0 eyal0 deleted the parallel_build_locale branch March 17, 2026 19:58
@eyal0 eyal0 mentioned this pull request Mar 17, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rampageservices rampageservices rampageservices approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

buildsystem Updates to the buildsystem (CMake/CTest/CPack)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eyal0 @rampageservices @spe-ciellt