fix: undef DPRINTF before redefining to avoid macOS warning#358
Merged
spe-ciellt merged 1 commit intogerbv:developfrom Mar 5, 2026
Merged
fix: undef DPRINTF before redefining to avoid macOS warning#358spe-ciellt merged 1 commit intogerbv:developfrom
spe-ciellt merged 1 commit intogerbv:developfrom
Conversation
macOS CarbonCore/Debugging.h defines DPRINTF(x) which conflicts with gerbv's variadic DPRINTF(...). Add #undef before each redefinition to suppress -Wmacro-redefined warnings on macOS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#undef DPRINTFbefore every#define DPRINTF(...)across all 17 source files-Wmacro-redefinedwarnings on macOS whereCarbonCore/Debugging.hdefinesDPRINTF(x)(single-arg) and gerbv redefines it as variadicDPRINTF(...)Test plan
-Wmacro-redefinedwarnings for DPRINTF