fix: Correct computation for bounding box of gerber files.#342
Merged
spe-ciellt merged 1 commit intogerbv:developfrom Mar 3, 2026
Merged
fix: Correct computation for bounding box of gerber files.#342spe-ciellt merged 1 commit intogerbv:developfrom
spe-ciellt merged 1 commit intogerbv:developfrom
Conversation
rampageservices
approved these changes
Mar 3, 2026
For the bounding box of an arc, we must consider the starting point, the end point, and every point that is at an x-axis or y-axis extent. Those occur at the angles that are multiples of 90 degrees. The `for` loop should iterate over those rather than every 90 degrees start from the start of the arc. Similar code is in `drill.c`. This fixes gerbv#336.
This was referenced Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the bounding box of an arc, we must consider the starting point, the end point, and every point that is at an x-axis or y-axis extent. Those occur at the angles that are multiples of 90 degrees. The
forloop should iterate over those rather than every 90 degrees start from the start of the arc.Similar code is in
drill.c.This fixes #336.