fix: document dxflib patches and remove dead tessellation guard#340
Merged
spe-ciellt merged 1 commit intogerbv:developfrom Mar 3, 2026
Merged
fix: document dxflib patches and remove dead tessellation guard#340spe-ciellt merged 1 commit intogerbv:developfrom
spe-ciellt merged 1 commit intogerbv:developfrom
Conversation
Add patch descriptions to thirdparty/dxflib/VERSION and remove the redundant `if (steps < 1) steps = 1` guard in DXF polygon arc tessellation — the `+ 1` in the preceding expression already guarantees steps >= 1. Addresses gerbv#334.
This was referenced Mar 3, 2026
Contributor
|
Perfect! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #334.
thirdparty/dxflib/VERSIONif (steps < 1) steps = 1guard in DXF polygon arc tessellation — the+ 1already guaranteessteps >= 1