fix: Put version number into libgerbv.pc correctly.#337
Merged
spe-ciellt merged 1 commit intogerbv:developfrom Mar 2, 2026
Merged
fix: Put version number into libgerbv.pc correctly.#337spe-ciellt merged 1 commit intogerbv:developfrom
spe-ciellt merged 1 commit intogerbv:developfrom
Conversation
Collaborator
Author
|
This has been a major issue for users of pcb2gcode. It causes I hope that you can push a new release with this. |
Collaborator
Author
Contributor
|
Even if you feeling stressed or anything I would be glad if you could fill out the description properly from the beginning. Especially on the Why part. But I will fix this now. |
Collaborator
Author
No problem! #337 (comment) Let me know if that is sufficient. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libgerbv.pc is used by the
pkg-configtool to get information about the installed version of libgerbv. It should look something like this:The
pkg-configtool can then extract the version of libgerbv by scanning through all the*.pcfiles on the computer. It works like this:However, if the
Versionin that file is missing, it will report nothing.The autotools programs use a
configurescript in order to configure a make file for building. (autotools is an older alternative to cmake.) One of the commands in the configure script might be like this:To check that the libgerbv version is at least 2.1.0.
However, if the libgerbv.pc file does not have a version, then it will fail and the user will be unable to complete configuration necessary for compilation.
By fixing libgerbv.pc, pkg-config will be able to report the correct version, and then configure will find that version and be able to create a makefile for programs that use libgerbv as a library.