Guard INCH/METRIC unit assignment with autod in drill header parsing (#241)#313
Merged
spe-ciellt merged 1 commit intogerbv:developfrom Mar 5, 2026
Merged
Conversation
drill_parse_header_is_inch() and drill_parse_header_is_metric() set state->unit unconditionally, overwriting user-supplied unit settings even when autodetect is disabled (state->autod == 0). The M-code handlers (DRILL_M_IMPERIAL, DRILL_M_METRIC) already guard their unit assignments with if(state->autod). Apply the same guard to the header parsing functions for consistency. Fixes gerbv#241
This was referenced Mar 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
state->unitassignments indrill_parse_header_is_inch()anddrill_parse_header_is_metric()withif (state->autod)Root cause
The M-code handlers (
DRILL_M_IMPERIAL,DRILL_M_METRIC) already guard their unit assignments withif (state->autod), but the header parsing functionsdrill_parse_header_is_inch()anddrill_parse_header_is_metric()setstate->unitunconditionally. When a user disables autodetect and manually sets the unit (e.g. METRIC), parsing anINCHheader command overwrites that setting.Test plan
Fixes #241