Merged
Conversation
It fails on MinGW which needs more thorough examination on why and how. Happy for the time being, since it compiles
Double backslash escape in config.h.in to get one single backslash escape config.h. That will then be unescaped backslash in the code hopefully.
…in Windows builds. The issue was the conflict between DATADIR macro and the Windows SDK's DATADIR enum type defined in objidl.h. By prefixing all the macros with GERBV_, we've avoided the namespace collision with the Windows headers while maintaining all the functionality.
Using %ld for printing out ssize_t is not platform independent and it became obvious when cross compiling using mingw. Using unsigned int for number of lines should be enough and thus using %u is platform independent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update CMake with cross compilation target to Windows using Mingw64.
Current status is it compiles.
Also a bunch of bug fixes and adaptions when different platforms and compiler versions come into play.