apply of '#81 Fix casting pointer to different size integer'#20
Closed
efa wants to merge 3 commits intogerbv:mainfrom
Closed
apply of '#81 Fix casting pointer to different size integer'#20efa wants to merge 3 commits intogerbv:mainfrom
efa wants to merge 3 commits intogerbv:mainfrom
Conversation
https://sourceforge.net/p/gerbv/patches/81/ as opening a .gvp file on Windows always crash
Contributor
|
I don't quite get this patch :-( |
https://sourceforge.net/p/gerbv/patches/81/ but changed 'uintptr_t' to 'size_t' as opening a .gvp file on Windows always crash I re-tested also on Linux
Contributor
Author
|
'size_t' has the same size of 'uintptr_t' used by @kitanokitsune on all 32 and 64-bit systems I know, and it is still unsigned, but it is certainly better for a size like adj=sizeof() |
Closed
Collaborator
|
Add a static_assert that the sizeof one is equal to the sizeof the other and then you will never have a question about whether or not the size is right. The compiler will tell you the answer with no effort. It's nice when the computer can enforce rules for us. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
apply of '#81 Fix casting pointer to different size integer'
https://sourceforge.net/p/gerbv/patches/81/
as opening a .gvp file on Windows always crash
This and the next one are necessary to work on Windows too.
Follow the PR for #77 Fix double-freeing memory