-
-
Notifications
You must be signed in to change notification settings - Fork 54
DXF export disabled in GUI/CLI after #374 merge #387
Copy link
Copy link
Closed
Labels
pr-fixesFixes that fixes fixes. Should refer to the original fix, not listed as fix in the release notes.Fixes that fixes fixes. Should refer to the original fix, not listed as fix in the release notes.
Description
#374 removed HAVE_LIBDXFLIB from config.h.in and config/CMakeLists.txt since dxflib is now always bundled, but the C source still guards DXF UI/CLI code behind #ifdef HAVE_LIBDXFLIB / #if HAVE_LIBDXFLIB (12 occurrences):
callbacks.c: lines 660, 836main.c: lines 514, 527, 540, 1203, 1237, 1500, 1517interface.c: lines 185, 448, 1379
Since the macro is never defined, DXF export menu items, file-save-as options, and CLI flags are compiled out. export-dxf.cpp is linked into libgerbv but the application never calls it.
Fix: remove the 12 guards and their #endif counterparts, since dxflib is now unconditionally available.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
pr-fixesFixes that fixes fixes. Should refer to the original fix, not listed as fix in the release notes.Fixes that fixes fixes. Should refer to the original fix, not listed as fix in the release notes.