On the current develop branch on a compute that does not have libdxf installed:

└──> objdump -t ./src/libgerbv.a | grep Dxf        
0000000000000000         *UND*	0000000000000000 _ZN6DL_DxfC1Ev
0000000000000000         *UND*	0000000000000000 _ZN6DL_Dxf3outEPKcN8DL_Codes7versionE
0000000000000000         *UND*	0000000000000000 _ZN6DL_Dxf11writeHeaderER10DL_WriterA
0000000000000000         *UND*	0000000000000000 _ZN6DL_Dxf10writeVPortER10DL_WriterA
0000000000000000         *UND*	0000000000000000 _ZN6DL_Dxf13writeLinetypeER10DL_WriterARK15DL_LinetypeData
0000000000000000         *UND*	0000000000000000 _ZN6DL_Dxf10writeLayerER10DL_WriterARK12DL_LayerDataRK13DL_Attributes
0000000000000000         *UND*	0000000000000000 _ZN6DL_Dxf10writeStyleER10DL_WriterARK12DL_StyleData
0000000000000000         *UND*	0000000000000000 _ZN6DL_Dxf9writeViewER10DL_WriterA
0000000000000000         *UND*	0000000000000000 _ZN6DL_Dxf8writeUcsER10DL_WriterA
0000000000000000         *UND*	0000000000000000 _ZN6DL_Dxf13writePolylineER10DL_WriterARK15DL_PolylineDataRK13DL_Attributes
0000000000000000         *UND*	0000000000000000 _ZN6DL_Dxf11writeVertexER10DL_WriterARK13DL_VertexData
0000000000000000         *UND*	0000000000000000 _ZN6DL_Dxf16writePolylineEndER10DL_WriterA
0000000000000000         *UND*	0000000000000000 _ZN6DL_Dxf12writeObjectsER10DL_WriterARKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEE
0000000000000000         *UND*	0000000000000000 _ZN6DL_Dxf15writeObjectsEndER10DL_WriterA
0000000000000000         *UND*	0000000000000000 _ZN6DL_DxfD1Ev
0000000000000000         *UND*	0000000000000000 _ZN6DL_Dxf8writeArcER10DL_WriterARK10DL_ArcDataRK13DL_Attributes
0000000000000000         *UND*	0000000000000000 _ZN6DL_Dxf11writeCircleER10DL_WriterARK13DL_CircleDataRK13DL_Attributes

We see that all these are undefined.

With the change (I've only included some of the lines):

└──> objdump -t ./src/libgerbv.a | grep Dxf
0000000000004710 g     F .text	0000000000000287 _ZN6DL_Dxf17writeDimAngular3PER10DL_WriterARK16DL_DimensionDataRK19DL_DimAngular3PDataRK13DL_Attributes
00000000000049a0 g     F .text	0000000000000216 _ZN6DL_Dxf16writeDimOrdinateER10DL_WriterARK16DL_DimensionDataRK18DL_DimOrdinateDataRK13DL_Attributes
0000000000004bc0 g     F .text	000000000000012c _ZN6DL_Dxf11writeLeaderER10DL_WriterARK13DL_LeaderDataRK13DL_Attributes
0000000000004cf0 g     F .text	0000000000000041 _ZN6DL_Dxf17writeLeaderVertexER10DL_WriterARK19DL_LeaderVertexData
0000000000004d40 g     F .text	000000000000009f _ZN6DL_Dxf14writeLeaderEndER10DL_WriterARK13DL_LeaderData
0000000000004de0 g     F .text	0000000000000167 _ZN6DL_Dxf11writeHatch1ER10DL_WriterARK12DL_HatchDataRK13DL_Attributes
0000000000004f50 g     F .text	0000000000000176 _ZN6DL_Dxf11writeHatch2ER10DL_WriterARK12DL_HatchDataRK13DL_Attributes
00000000000050d0 g     F .text	0000000000000039 _ZN6DL_Dxf15writeHatchLoop1ER10DL_WriterARK16DL_HatchLoopData
0000000000005110 g     F .text	0000000000000013 _ZN6DL_Dxf15writeHatchLoop2ER10DL_WriterARK16DL_HatchLoopData
0000000000005130 g     F .text	00000000000004f7 _ZN6DL_Dxf14writeHatchEdgeER10DL_WriterARK16DL_HatchEdgeData
0000000000005630 g     F .text	00000000000001f2 _ZN6DL_Dxf10writeImageER10DL_WriterARK12DL_ImageDataRK13DL_Attributes
0000000000005830 g     F .text	0000000000000126 _ZN6DL_Dxf13writeImageDefER10DL_WriterAiRK12DL_ImageData
0000000000005960 g     F .text	000000000000043d _ZN6DL_Dxf10writeLayerER10DL_WriterARK12DL_LayerDataRK13DL_Attributes
0000000000005da0 g     F .text	0000000000000416 _ZN6DL_Dxf13writeLinetypeER10DL_WriterARK15DL_LinetypeData
00000000000061c0 g     F .text	00000000000001cd _ZN6DL_Dxf10writeAppidER10DL_WriterARKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEE
0000000000006390 g     F .text	00000000000002fa _ZN6DL_Dxf10writeBlockER10DL_WriterARK12DL_BlockData
0000000000006690 g     F .text	0000000000000234 _ZN6DL_Dxf13writeEndBlockER10DL_WriterARKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEE
00000000000068d0 g     F .text	00000000000004d7 _ZN6DL_Dxf10writeVPortER10DL_WriterA
0000000000006db0 g     F .text	000000000000020b _ZN6DL_Dxf10writeStyleER10DL_WriterARK12DL_StyleData

We see many functions are defined. This will allow users to link to libgerbv.a even if they don't have libdxf installed.

I ran into this problem while working on pcb2gcode: https://github.com/eyal0/pcb2gcode/actions/runs/22734840676/job/65933332720

Uh oh!

libgerbv is not installing correctly #366

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions