Responsive Design - Info Box#5861
Merged
offtherailz merged 4 commits intogeosolutions-it:masterfrom Sep 22, 2020
Merged
Conversation
offtherailz
requested changes
Sep 17, 2020
Member
There was a problem hiding this comment.
It seems a nice work. 🚀
I've only to ask some things for maintainance
- I see
loadedDatahere and there, The shape and the properties are not clear. Can you document more additional properties you added or use the commonlinkedResourcesshape if possible. Less additional properties we have, more the code is easy to understand and to maintain. And they all have to be documented. - Unit tests
- About the wysiwyg editor functionalities I suggest to try what @vlt1 was able to provide without forking and see if it is enough @tdipisa . In case we need a better tool, we can open a separate issue.
By default mapstore uses the burger menu.
offtherailz
approved these changes
Sep 21, 2020
Member
offtherailz
left a comment
There was a problem hiding this comment.
@vlt1 I committed the tooltip for the detail card in the Toolbar and I changed priority for default MapStore.
You can restore this by setting in localConfig.json of the project this:
{
"name": "Details",
"override": {
"Toolbar": {
"priority": 10
}
}
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
austrocontrol-C125/#160 and partly austrocontrol-C125/#162. The issue with the editor needs to be resolved separately as it involves creating a new element from scratch in react-draft-wysiwyg. The relevant discussion is in the old pr.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
austrocontrol-C125/#160
austrocontrol-C125/#162
What is the new behavior?
Details sheet row has two new buttons for options, draftjs details editor is added.
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)