Skip to content

columnSettings label display#5801

Merged
offtherailz merged 2 commits intogeosolutions-it:masterfrom
mgogh:master
Sep 4, 2020
Merged

columnSettings label display#5801
offtherailz merged 2 commits intogeosolutions-it:masterfrom
mgogh:master

Conversation

@mgogh
Copy link
Copy Markdown
Contributor

@mgogh mgogh commented Aug 19, 2020

Description

check if columnSettings as label key for an attribute and display it

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Feature

What is the new behavior?
Display label of an attribute if sets in columnSettings property.

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • No

check if columnSettings as label key for an attribute and display it
@coveralls
Copy link
Copy Markdown

coveralls commented Aug 19, 2020

Coverage Status

Coverage increased (+0.003%) to 83.522% when pulling f76eb82 on mgogh:master into 97f4a09 on geosolutions-it:master.

Use "key" attribute instead of "name", allowing developpers to use "name" for a better display (translation, from csw catalog, etc) in the catalog attribute for headers.
"key" field, used as a referential.
@offtherailz offtherailz self-requested a review August 31, 2020 13:49
@offtherailz
Copy link
Copy Markdown
Member

It looks a good feature to use in a custom project
It's also an initial support to possible UI for column set-up. Do you have same samples about it ?
No problem to merge it, thank you 👍
If you provide a unit test, we are more secure that this feature will be maintained in the future.

@offtherailz offtherailz merged commit 5663c6e into geosolutions-it:master Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants