Skip to content

fixed some spanish translations#3807

Merged
mbarto merged 3 commits intogeosolutions-it:masterfrom
arp43b:fix_translations
May 27, 2019
Merged

fixed some spanish translations#3807
mbarto merged 3 commits intogeosolutions-it:masterfrom
arp43b:fix_translations

Conversation

@arp43b
Copy link
Copy Markdown
Contributor

@arp43b arp43b commented May 27, 2019

Description

A few sentences describing the overall goals of the pull request' s commits.

Issues

  • Fix #
  • ...

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)

What is the new behavior?

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

Copy link
Copy Markdown
Contributor

@MV88 MV88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've noticed some records have been removed, can you please restore them and double check ?

"errorDelete": "A ocurrido un error al borrar el usuario:",
"errorSaving": "A ocurrido un error al guardar el usuario:",
"selectedGroups": "GRUPOS SELECCIONADOS",
"requiredFiedsMessage": "Se requiere llenar campos marcados con asterisco (*)"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi, please do not remove any record

"msgToCopyUrl": "Pinche para copiar",
"sharedTitle": "Mira mi nuevo mapa: ",
"advancedOptions": "Opciones avanzadas",
"addBboxParam": "Añadir bbox param al enlace de compartir",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above, please do not remove any record

@mbarto
Copy link
Copy Markdown
Contributor

mbarto commented May 27, 2019

@MV88, @arp43b I should have added back all the missing stuff, please check

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.008%) to 81.419% when pulling ef98513 on arp43b:fix_translations into 7fb4e66 on geosolutions-it:master.

@mbarto
Copy link
Copy Markdown
Contributor

mbarto commented May 27, 2019

Ok, it looks good now.
Thanks for the contribution @arp43b much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants