Skip to content

Fix #3450 Added docker files to standard proj#3780

Merged
MV88 merged 2 commits intogeosolutions-it:masterfrom
MV88:3450_dockerfiles
May 21, 2019
Merged

Fix #3450 Added docker files to standard proj#3780
MV88 merged 2 commits intogeosolutions-it:masterfrom
MV88:3450_dockerfiles

Conversation

@MV88
Copy link
Copy Markdown
Contributor

@MV88 MV88 commented May 21, 2019

Description

  • changed the required param and default for description
  • changed the error message with specific invalid param

Issues

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes (create standard project )
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
when you create a prroject with createProject.js the docker file and folder are missing

What is the new behavior?
the are no longer missing

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

* changed the required param and default fro description
* changed the error message with specific invalid param
@MV88 MV88 added enhancement Environment Tasks related to GeoSolutions build and deploy environments labels May 21, 2019
@MV88 MV88 requested a review from mbarto May 21, 2019 10:49
@MV88 MV88 self-assigned this May 21, 2019
@coveralls
Copy link
Copy Markdown

coveralls commented May 21, 2019

Coverage Status

Coverage increased (+27.4%) to 81.41% when pulling cd0f43d on MV88:3450_dockerfiles into cd4e046 on geosolutions-it:master.

@MV88 MV88 merged commit b6aa87c into geosolutions-it:master May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Environment Tasks related to GeoSolutions build and deploy environments

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants