Skip to content

#3767 resizable flag for DrawerMenu plugin#3770

Merged
mbarto merged 1 commit intogeosolutions-it:masterfrom
mbarto:resizable_drawer
May 20, 2019
Merged

#3767 resizable flag for DrawerMenu plugin#3770
mbarto merged 1 commit intogeosolutions-it:masterfrom
mbarto:resizable_drawer

Conversation

@mbarto
Copy link
Copy Markdown
Contributor

@mbarto mbarto commented May 20, 2019

Description

Optional flag to add horizontal resize behaviour to DrawerMenu.

Issues

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
DrawerMenu is not resizable

What is the new behavior?
When cfg.menuOptions.resizable is true in the DrawerMenu plugin cfg, the DrawerMenu becomes resizable horizontally.

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@mbarto mbarto added this to the 2019.02.00 milestone May 20, 2019
@mbarto mbarto requested a review from allyoucanmap May 20, 2019 12:51
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.04%) to 81.41% when pulling 32b9c55 on mbarto:resizable_drawer into 982e7c9 on geosolutions-it:master.

@mbarto mbarto merged commit 3c22994 into geosolutions-it:master May 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Introduce flag in DrawerMenu to make it resizable

3 participants