Skip to content

Fix #3083 - When adding a new group/user is not clear which section is opened#3752

Merged
MV88 merged 4 commits intogeosolutions-it:masterfrom
gia8789:fix_3083
May 17, 2019
Merged

Fix #3083 - When adding a new group/user is not clear which section is opened#3752
MV88 merged 4 commits intogeosolutions-it:masterfrom
gia8789:fix_3083

Conversation

@gia8789
Copy link
Copy Markdown
Contributor

@gia8789 gia8789 commented May 14, 2019

Description

Changing the buttons color when selected in tabs to create a new user or a new group

Issues

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
see #3083

What is the new behavior?
Buttons becomes green when selected

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@coveralls
Copy link
Copy Markdown

coveralls commented May 14, 2019

Coverage Status

Coverage increased (+0.002%) to 81.439% when pulling ac40923 on gia8789:fix_3083 into 5701635 on geosolutions-it:master.

Copy link
Copy Markdown
Contributor

@MV88 MV88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is fine, but some tests are failing.

When running npm run continuoustest I see two tests failing. can you fix those?

Here you can see the travis build with the failing errors

@MV88 MV88 merged commit 982e7c9 into geosolutions-it:master May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants