Skip to content

Closes #3695 Wrong west coordinates in mouse position#3728

Merged
offtherailz merged 2 commits intogeosolutions-it:masterfrom
kappu72:issue#3695
May 10, 2019
Merged

Closes #3695 Wrong west coordinates in mouse position#3728
offtherailz merged 2 commits intogeosolutions-it:masterfrom
kappu72:issue#3695

Conversation

@kappu72
Copy link
Copy Markdown
Contributor

@kappu72 kappu72 commented May 7, 2019

Description

Fixed wrong coordinates in mouse position plugin

Issues

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
Mouse positions shows wrong coordinates when close to -0

What is the new behavior?
Coordinates are correct

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@ghost ghost assigned kappu72 May 7, 2019
@coveralls
Copy link
Copy Markdown

coveralls commented May 7, 2019

Coverage Status

Coverage increased (+0.03%) to 81.387% when pulling dde48e5 on kappu72:issue#3695 into d3a2a2a on geosolutions-it:master.

@tdipisa tdipisa added this to the 2019.01.01 milestone May 7, 2019
@MV88 MV88 changed the title Closes #3695 Closes #3695 Wrong west coordinates in mouse position May 7, 2019
Copy link
Copy Markdown
Member

@offtherailz offtherailz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a unit test

@offtherailz offtherailz merged commit ca2e60f into geosolutions-it:master May 10, 2019
@tdipisa
Copy link
Copy Markdown
Member

tdipisa commented May 10, 2019

@kappu72 please backport this to the 2019.01.xx branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong west coordinates in mouse position

4 participants