Skip to content

Fix #3712 SLD styles version 1.1.0 are not saved correctly from Style Editor (2019.01.xx)#3724

Merged
offtherailz merged 1 commit intogeosolutions-it:2019.01.xxfrom
allyoucanmap:sldse-styleeditor-19.01
May 7, 2019
Merged

Fix #3712 SLD styles version 1.1.0 are not saved correctly from Style Editor (2019.01.xx)#3724
offtherailz merged 1 commit intogeosolutions-it:2019.01.xxfrom
allyoucanmap:sldse-styleeditor-19.01

Conversation

@allyoucanmap
Copy link
Copy Markdown
Contributor

@allyoucanmap allyoucanmap commented May 6, 2019

Description

This PR introduces following changes to verify version of SLD style is correctly updated in the editing phase.
changes:

  • temporary style will be replaced when style editor switches format
  • Style Editor sends every save POST request with param raw equal true to ensure correct update of the version
  • If SLD changes version, Style Editor sends POST/PUT requests for temporary style with raw equal to true
  • disabled editing for unsupported format (currently it is not possible to edit style such as mbstyle or ysld)

ui with editing disabled
2019-05-06 09_40_44-Window

Issues

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix

What is the current behavior? (You can also link to an open issue here)
#3712

What is the new behavior?

  • temporary style will be replaced when style editor switches format
  • Style Editor sends every save POST request with param raw equal true to ensure correct update of the version
  • If SLD changes version, Style Editor sends POST/PUT requests for temporary style with raw equal to true
  • disabled editing for unsupported format

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@allyoucanmap
Fix geosolutions-it#3712 SLD styles version 1.1.0 are not saved corre…
1bfb591 
…ctly from Style Editor (geosolutions-it#3718)

* add control for sld version 1.1.0 and minor update o style editor

* updated styles epics

* remove comment
@ghost ghost assigned allyoucanmap May 6, 2019
@coveralls
Copy link
Copy Markdown

coveralls commented May 6, 2019

Coverage Status

Coverage decreased (-0.01%) to 81.233% when pulling 1bfb591 on allyoucanmap:sldse-styleeditor-19.01 into ed530d1 on geosolutions-it:2019.01.xx.

@offtherailz offtherailz merged commit 2297f0e into geosolutions-it:2019.01.xx May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@allyoucanmap allyoucanmap

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@allyoucanmap @coveralls @offtherailz