Skip to content

autoDetectCORS option for proxy config#3681

Merged
offtherailz merged 3 commits intogeosolutions-it:masterfrom
mbarto:auto_detect_cors
Apr 12, 2019
Merged

autoDetectCORS option for proxy config#3681
offtherailz merged 3 commits intogeosolutions-it:masterfrom
mbarto:auto_detect_cors

Conversation

@mbarto
Copy link
Copy Markdown
Contributor

@mbarto mbarto commented Apr 9, 2019

Description

Optional configuration to introduce autodetect of CORS on services used by MapStore2.
If enabled, when contacting any service, MS2 will try to contact it directly, on error will fallback to using the proxy (and continue to use the proxy for following requests)

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
CORS is enabled only if an host is listed in useCORS configuration option.

What is the new behavior?
CORS is autodetected and proxy is only used as a fallback.

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@ghost ghost assigned mbarto Apr 9, 2019
@mbarto mbarto added this to the 2019.02.00 milestone Apr 9, 2019
@mbarto mbarto requested a review from offtherailz April 9, 2019 12:42
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.01%) to 81.007% when pulling b7b56fb on mbarto:auto_detect_cors into 19ddd55 on geosolutions-it:master.

@offtherailz offtherailz merged commit 571b52d into geosolutions-it:master Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants