Skip to content

Fixes #3441: root dir cleanup#3680

Merged
offtherailz merged 2 commits intogeosolutions-it:masterfrom
mbarto:clean_root
Apr 12, 2019
Merged

Fixes #3441: root dir cleanup#3680
offtherailz merged 2 commits intogeosolutions-it:masterfrom
mbarto:clean_root

Conversation

@mbarto
Copy link
Copy Markdown
Contributor

@mbarto mbarto commented Apr 9, 2019

Description

Cleaned up root dir from a bunch of scripts / configuration files, mainly related to building the application.

Issues

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... files moving

What is the current behavior? (You can also link to an open issue here)
A lot of files are in the root folder.

What is the new behavior?
Most of the scripts / configuration files related to build and project creation have been moved to subfolder.

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: Projects that will update to this version will need to update some of the building configuration (e.g. webpack.config.js, karma configuration files) to point to new file locations.

Other information:

@mbarto mbarto added this to the 2019.01.01 milestone Apr 9, 2019
@mbarto mbarto requested a review from offtherailz April 9, 2019 11:34
@ghost ghost assigned mbarto Apr 9, 2019
@coveralls
Copy link
Copy Markdown

coveralls commented Apr 9, 2019

Coverage Status

Coverage increased (+0.02%) to 81.014% when pulling 985b65d on mbarto:clean_root into 19ddd55 on geosolutions-it:master.

@MV88
Copy link
Copy Markdown
Contributor

MV88 commented Apr 11, 2019

please update migration guide

Copy link
Copy Markdown
Member

@offtherailz offtherailz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job. Please document it in migration notes.

@geosolutions-it geosolutions-it deleted a comment Apr 12, 2019
@offtherailz offtherailz merged commit d542545 into geosolutions-it:master Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Root Dir Clean up

4 participants