Skip to content

Fix #2996. Support for RESTful WMTS with Multiple URLs#3595

Merged
offtherailz merged 11 commits intogeosolutions-it:masterfrom
offtherailz:fix_#2996
Mar 5, 2019
Merged

Fix #2996. Support for RESTful WMTS with Multiple URLs#3595
offtherailz merged 11 commits intogeosolutions-it:masterfrom
offtherailz:fix_#2996

Conversation

@offtherailz
Copy link
Copy Markdown
Member

@offtherailz offtherailz commented Mar 4, 2019

Description

This pull request:

  • Add support to WTMS RESTful for leaflet/openlayers and cesium
  • Disable FeatureInfo for WMTS when not available in operations.
  • Support WMTS services with multiple ResourceURL (for domain sharding)

Issues

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Feature

What is the current behavior? (You can also link to an open issue here)
WMTS RESTFul where not supported.

What is the new behavior?
WMTS RESTFul are now supported. (BaseMap.at). ResourceURLs of layers are used for domain sharding

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • No

Notes for review and Devs

  • I moved sources extract/apply to layer logic on the LayerUtils object (before extract and apply to layer logic was divided between MapUtils and Layer Utils).
  • I had to fix replacePlaceholders to avoid to replace with an empty string the placeholder not found. This because it was removing the {TileCol} etc.. from the REST URLs templates of WMTS layers.

@offtherailz offtherailz marked this pull request as ready for review March 4, 2019 17:36
@offtherailz offtherailz requested a review from mbarto March 4, 2019 17:36
Copy link
Copy Markdown
Contributor

@mbarto mbarto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment, looks good in general

```

#### WMTS
WMTS Layer require a source object in the `sources` object of the map configuration where to retrieve the `tileMatrixSet`. The source is identified by the `capabilitiesURL`.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a fallback for old maps? If capabilitiesURL is not present, will it work as before?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we have. I specified it in the KVP example. Maybe is a good thing if I specify it also here.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See LayerUtils.js => getSourceId

@offtherailz offtherailz merged commit c55f1ed into geosolutions-it:master Mar 5, 2019
@coveralls
Copy link
Copy Markdown

coveralls commented Mar 6, 2019

Coverage Status

Coverage increased (+0.01%) to 80.934% when pulling 7cb85e7 on offtherailz:fix_#2996 into 2371e02 on geosolutions-it:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WMTS issue basemap.at

4 participants