Fix #2996. Support for RESTful WMTS with Multiple URLs#3595
Merged
offtherailz merged 11 commits intogeosolutions-it:masterfrom Mar 5, 2019
Merged
Fix #2996. Support for RESTful WMTS with Multiple URLs#3595offtherailz merged 11 commits intogeosolutions-it:masterfrom
offtherailz merged 11 commits intogeosolutions-it:masterfrom
Conversation
mbarto
reviewed
Mar 5, 2019
Contributor
mbarto
left a comment
There was a problem hiding this comment.
Just a comment, looks good in general
| ``` | ||
|
|
||
| #### WMTS | ||
| WMTS Layer require a source object in the `sources` object of the map configuration where to retrieve the `tileMatrixSet`. The source is identified by the `capabilitiesURL`. |
Contributor
There was a problem hiding this comment.
Do we have a fallback for old maps? If capabilitiesURL is not present, will it work as before?
Member
Author
There was a problem hiding this comment.
Yes, we have. I specified it in the KVP example. Maybe is a good thing if I specify it also here.
Member
Author
There was a problem hiding this comment.
See LayerUtils.js => getSourceId
mbarto
approved these changes
Mar 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request:
Issues
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
What is the current behavior? (You can also link to an open issue here)
WMTS RESTFul where not supported.
What is the new behavior?
WMTS RESTFul are now supported. (BaseMap.at). ResourceURLs of layers are used for domain sharding
Does this PR introduce a breaking change? (check one with "x", remove the other)
Notes for review and Devs