Skip to content

Some improvements for #3523 address and coordinate search#3559

Merged
tdipisa merged 2 commits intogeosolutions-it:masterfrom
MV88:3523_improvements
Feb 22, 2019
Merged

Some improvements for #3523 address and coordinate search#3559
tdipisa merged 2 commits intogeosolutions-it:masterfrom
MV88:3523_improvements

Conversation

@MV88
Copy link
Copy Markdown
Contributor

@MV88 MV88 commented Feb 21, 2019

Description

Removed burger menu from the toolbar in the searchBar in embedded mode
added two new options for configuring the burger menu options list
by default they are true

  • "showCoordinatesSearchOption": true
  • "showAddressSearchOption": true

Issues

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
you cannot disable the address search tool or the coordinate search tool

What is the new behavior?
you can disable one search tool, and the other is by default enabled

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:
for showing only the addresses search

{
"name": "Search",
"cfg": {
  "showCoordinatesSearchOption": false,
  "withToggle": ["max-width: 768px", "min-width: 768px"]
  }
}

for showing only the coordiantes search

{
"name": "Search",
"cfg": {
  "showAddressSearchOption": false,
  "withToggle": ["max-width: 768px", "min-width: 768px"]
  }
}

for removing the burger menu option:

{
"name": "Search",
"cfg": {
  "showOptions": false,
  "withToggle": ["max-width: 768px", "min-width: 768px"]
  }
}

@tdipisa tdipisa merged commit 85cc05d into geosolutions-it:master Feb 22, 2019
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.006%) to 80.966% when pulling b3787ea on MV88:3523_improvements into 8b8a73c on geosolutions-it:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Address and coordinate search

5 participants