Fix #3138. Avoid purgeMapInfoResults to refresh layout#3558
Merged
offtherailz merged 1 commit intogeosolutions-it:masterfrom Feb 21, 2019
Merged
Fix #3138. Avoid purgeMapInfoResults to refresh layout#3558offtherailz merged 1 commit intogeosolutions-it:masterfrom
offtherailz merged 1 commit intogeosolutions-it:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request solves issue #3138. Probably the issue was solved, that found some error and reverted, but the issue, for some reason, remained closed.
The problem is that, when the action PURGE_MAPINFO_RESULT is performed, the mapLayout is updated, triggering the resize. Instead of this, this should happen only on FEATUREINFO_CLOSE.
PURGE_MAPINFO_RESULT is triggered also by feature grid and annotation tools to colose the feature info tool. So I fixed them to trigger also closeIdentify action.
So
Please test annotations and feature grid open/close events to identify possible problems that this refactor caused
Issues
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
What is the current behavior? (You can also link to an open issue here)
See #3138.
What is the new behavior?
Glitch do not happen anymore. The application triggers also closeIdentify also on featuregrid open or annotation remove..
Does this PR introduce a breaking change? (check one with "x", remove the other)